Can I improve this code?
0
It took me four hours to write this lol, I'm trying to learn and was wondering if this could be improved or cleaned up at all. The idea is the user selects one of the three categories then makes a note on that selection. Then the note is appended and saved to the appropriate list. Thanks in advance!
#!/bin/bash
#get the date
date=$(date +%d-%B-%Y)
#save locations
wsave="${HOME}/worknotes.txt"
shsave="${HOME}/shoppingnotes.txt"
scsave="${HOME}/schoolnotes.txt"
#list
while [ true ]
do
read -p "What is this note for?
Work
School
Shopping
> " topic
case $topic in
"Work" )
read -p "
Note
> " wnote
echo "$date: $wnote" >> "$wsave"
echo "Note saved to $wsave"
break
;;
"Shopping" )
read -p "
Note
> " shnote
echo "$date: $shnote" >> "$shsave"
echo "Note saved to $shsave"
break
;;
"School" )
read -p "
Note
> " scnote
echo "$date: $scnote" >> "$scsave"
echo "Note saved to $scsave"
break
;;
*) echo "Error: Selection was not on list, try again.
"
;;
esac
done
linux bash shell-script shell
asked 2 hours ago
Ryan RRyan R
183
add a comment |
0
It took me four hours to write this lol, I'm trying to learn and was wondering if this could be improved or cleaned up at all. The idea is the user selects one of the three categories then makes a note on that selection. Then the note is appended and saved to the appropriate list. Thanks in advance!
#!/bin/bash
#get the date
date=$(date +%d-%B-%Y)
#save locations
wsave="${HOME}/worknotes.txt"
shsave="${HOME}/shoppingnotes.txt"
scsave="${HOME}/schoolnotes.txt"
#list
while [ true ]
do
read -p "What is this note for?
Work
School
Shopping
> " topic
case $topic in
"Work" )
read -p "
Note
> " wnote
echo "$date: $wnote" >> "$wsave"
echo "Note saved to $wsave"
break
;;
"Shopping" )
read -p "
Note
> " shnote
echo "$date: $shnote" >> "$shsave"
echo "Note saved to $shsave"
break
;;
"School" )
read -p "
Note
> " scnote
echo "$date: $scnote" >> "$scsave"
echo "Note saved to $scsave"
break
;;
*) echo "Error: Selection was not on list, try again.
"
;;
esac
done
linux bash shell-script shell
asked 2 hours ago
Ryan RRyan R
183
1
Requests for improvement of working code usually belong on codereview.stackexchange.com . You might get better suggestions there.
– John1024
2 hours ago
From reading the code I'd say the only thing that is actually affected by the user's choice is the filename the note gets appended to. That is one thing. But you have three statements in your case specific code...
– Bananguin
37 mins ago
add a comment |
0
0
0
It took me four hours to write this lol, I'm trying to learn and was wondering if this could be improved or cleaned up at all. The idea is the user selects one of the three categories then makes a note on that selection. Then the note is appended and saved to the appropriate list. Thanks in advance!
#!/bin/bash
#get the date
date=$(date +%d-%B-%Y)
#save locations
wsave="${HOME}/worknotes.txt"
shsave="${HOME}/shoppingnotes.txt"
scsave="${HOME}/schoolnotes.txt"
#list
while [ true ]
do
read -p "What is this note for?
Work
School
Shopping
> " topic
case $topic in
"Work" )
read -p "
Note
> " wnote
echo "$date: $wnote" >> "$wsave"
echo "Note saved to $wsave"
break
;;
"Shopping" )
read -p "
Note
> " shnote
echo "$date: $shnote" >> "$shsave"
echo "Note saved to $shsave"
break
;;
"School" )
read -p "
Note
> " scnote
echo "$date: $scnote" >> "$scsave"
echo "Note saved to $scsave"
break
;;
*) echo "Error: Selection was not on list, try again.
"
;;
esac
done
linux bash shell-script shell
asked 2 hours ago
Ryan RRyan R
183
It took me four hours to write this lol, I'm trying to learn and was wondering if this could be improved or cleaned up at all. The idea is the user selects one of the three categories then makes a note on that selection. Then the note is appended and saved to the appropriate list. Thanks in advance!
#!/bin/bash
#get the date
date=$(date +%d-%B-%Y)
#save locations
wsave="${HOME}/worknotes.txt"
shsave="${HOME}/shoppingnotes.txt"
scsave="${HOME}/schoolnotes.txt"
#list
while [ true ]
do
read -p "What is this note for?
Work
School
Shopping
> " topic
case $topic in
"Work" )
read -p "
Note
> " wnote
echo "$date: $wnote" >> "$wsave"
echo "Note saved to $wsave"
break
;;
"Shopping" )
read -p "
Note
> " shnote
echo "$date: $shnote" >> "$shsave"
echo "Note saved to $shsave"
break
;;
"School" )
read -p "
Note
> " scnote
echo "$date: $scnote" >> "$scsave"
echo "Note saved to $scsave"
break
;;
*) echo "Error: Selection was not on list, try again.
"
;;
esac
done
linux bash shell-script shell
linux bash shell-script shell
asked 2 hours ago
Ryan RRyan R
183
asked 2 hours ago
Ryan RRyan R
183
asked 2 hours ago
Ryan RRyan R
183
asked 2 hours ago
Ryan RRyan R
183
asked 2 hours ago
Ryan RRyan R
183
183
1
Requests for improvement of working code usually belong on codereview.stackexchange.com . You might get better suggestions there.
– John1024
2 hours ago
From reading the code I'd say the only thing that is actually affected by the user's choice is the filename the note gets appended to. That is one thing. But you have three statements in your case specific code...
– Bananguin
37 mins ago
add a comment |
1
Requests for improvement of working code usually belong on codereview.stackexchange.com . You might get better suggestions there.
– John1024
2 hours ago
From reading the code I'd say the only thing that is actually affected by the user's choice is the filename the note gets appended to. That is one thing. But you have three statements in your case specific code...
– Bananguin
37 mins ago
1
1
Requests for improvement of working code usually belong on codereview.stackexchange.com . You might get better suggestions there.
– John1024
2 hours ago
Requests for improvement of working code usually belong on codereview.stackexchange.com . You might get better suggestions there.
– John1024
2 hours ago
From reading the code I'd say the only thing that is actually affected by the user's choice is the filename the note gets appended to. That is one thing. But you have three statements in your case specific code...
– Bananguin
37 mins ago
From reading the code I'd say the only thing that is actually affected by the user's choice is the filename the note gets appended to. That is one thing. But you have three statements in your case specific code...
– Bananguin
37 mins ago
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "106"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2funix.stackexchange.com%2fquestions%2f505732%2fcan-i-improve-this-code%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Unix & Linux Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2funix.stackexchange.com%2fquestions%2f505732%2fcan-i-improve-this-code%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
Requests for improvement of working code usually belong on codereview.stackexchange.com . You might get better suggestions there.
– John1024
2 hours ago
From reading the code I'd say the only thing that is actually affected by the user's choice is the filename the note gets appended to. That is one thing. But you have three statements in your case specific code...
– Bananguin
37 mins ago